search

tbosch / autofill-event

A polyfill to fire a change event when the browser auto fills form fields
MIT License
383 stars 53 forks source link

Manual test failed in Chromium #12

Open qstrahl opened 10 years ago

qstrahl commented 10 years ago

edgsesy

$ chromium --version
Chromium 33.0.1750.46
tbosch commented 10 years ago

Hi, mmh, haven't tested on Chromium yet, sorry.

barnabas-scout commented 10 years ago

Thanks very much for your extension, first of all. I've done some investigation and tried to hack a fix but have come up short. Anyway, this problem exists on Chrome 37.0.2062.120 m and 37.0.2062.124 m on Windows 7 today. I was also able to cause a screen that looks like the screenshot above in Firefox 32.0.3 today. firefox-autofill-event

I'm not sure why the password type is now special. I can say that in debugging, markValue is only called three times, not four. For the first two times, it is called for both inputs by addValueChangeByJsListener.

However, the third time markEvent is called, the call stack indicates that it was by the onEvent function inside of addGlobalEventListener for the "change" event. One would expect a corresponding "change" event to be fired by the password input, but that does not happen in Chrome, anyway.

For Chrome, you can get the Angular bound "Password" value to fill if you click anywhere on the page, even if it's not in the inputs themselves. For Firefox, Password value even updates when the Firefox window looses focus. I hope this helps.