search

tboudreaux / gource

Automatically exported from code.google.com/p/gource
0 stars 0 forks source link

Non-ASCII characters not supported in committer names #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
If a committer has non-ASCII characters in his name, all his commits will
be attributed to some other committer. To take my name for example, I had
to do "sed -i 's/Hinrik Örn Sigurðsson/Hinrik Orn Sigurdsson/'" on the log
file for my commits to be attributed correctly.

It doesn't matter whether the log file is in UTF-8 or ISO-8859-1, gource
chokes on non-ASCII names in both cases.

Original issue reported on code.google.com by hinrik....@gmail.com on 16 Sep 2009 at 8:31

GoogleCodeExporter commented 8 years ago

Original comment by acaudw...@gmail.com on 17 Sep 2009 at 1:32

GoogleCodeExporter commented 8 years ago 
Gource can already display UTF8 if you disable the character checking in
commitlog.h:isValid()

The problem is, without this invalid character sequences can get through that 
cause a
seg fault in freetype2. Eg this commit to the linux kernel git (yes git-log 
gives you
non utf-8 sometimes even when you ask for it).

commit 2b422383c3d8dcd203dd9aea70155be6258dbf6c
tree 782191641d55a95424dce1d5b6c8a19290423344
parent 44fc355db7c224c95752155c54cbe28380f14c19
author H<E5>kon L<F8>vdal <...> 1142883124 +0100
...

So we need some way to validate usernames to detect cases like the above.

Maybe someone affected would like to implement this :)

Original comment by acaudw...@gmail.com on 21 Sep 2009 at 6:01

GoogleCodeExporter commented 8 years ago 
Ok never mind I found this. http://utfcpp.sourceforge.net/

Will be fixed in the next release.

Original comment by acaudw...@gmail.com on 21 Sep 2009 at 11:00

GoogleCodeExporter commented 8 years ago

Original comment by acaudw...@gmail.com on 22 Sep 2009 at 8:03