tbowmo / node-red-contrib-mysensors

Mysensor nodes for node-red
23 stars 9 forks source link

myscontroller output is missing newline #29

Open tilegg opened 4 years ago

tilegg commented 4 years ago

The output channel of myscontroller is not adding a newline at the end of the message payload. This prevents the ethernet gateway from accepting/sending the message.

This prevents node-id assignments from working when using the ethernet gateway. Can be worked around by adding a JS-Function that appends newline to the messages payload. Once this is added node-id assignment works as expected.

Example transmission:

Incoming message:

10;255;3;0;6;0\n
"INTERNAL;nodeId:10;childId:255;SubType:I_CONFIG;ACK:0;Payload:0"

Actual message sent: 10;255;3;0;6;M

Expected message 10;255;3;0;6;M\n

mariusl commented 1 year ago

This seems to be an very old issue and still not resolved. I am using the serial gateway and after appending the \n the payload string I still don't get my sensors to react. If I connect the gateway to a terminal and send the exact message manually, it works fine. Is there a way to determine what is actually sent by the node?

tbowmo commented 1 year ago

Long overdue, but this should be fixed now, as I have added an option for adding newlines to output from controller node

@mariusl / @tilegg could any of you test 4.2.0?