tbox1911 / Liberation-RX

ArmA 3 - Liberation RX - Mission
GNU General Public License v3.0
64 stars 61 forks source link

ACE Arsenal is broken #116

Closed sturmalex closed 1 year ago

sturmalex commented 1 year ago

Hi there,

when accessing the arsenal with ACE enabled and e.g. RHS US vs RHS RU the whole content of weapons. Vanilla, DLC, CDLC and other Mods is available despite having "strict" mode set in parameters.

The Items are not selectable though, when you select them and exit the arsenal the item disappears

thanks and BR Alex

tbox1911 commented 1 year ago

hello, thanks, I'll look a that !

sturmalex commented 1 year ago

Hi tbox,

merci beaucoup! :-)

Also I realized when using ACE Arsenal the Mission switches from Strict to Strict+ Mode. Is there any reason to that?

I tinkered a bit.....

File: liberationArsenal.sqf.

If you dont pass if (GRLIB_ACE_enabled) then { [myLARsBox, true, false] call ace_arsenal_fnc_initBox }; in Line 72 but pass if (GRLIB_ACE_enabled) then { [myLARsBox, GRLIB_whitelisted_from_arsenal, false] call ace_arsenal_fnc_initBox }; in line 86 it shows the correct items.

In this case ACE Items are missing though, I added a logic to the ace filtering to (hopefully) add all ACE Items to the whitelist.

I tested it and: did you know that you can stuff 240 Bananas into the Eagle Bag? lol.

I have created a solution IMO Check my Pull request: https://github.com/tbox1911/Liberation-RX/pull/117

BR Alex

sturmalex commented 1 year ago

Okay, I just realized, that there are weapons like launchers added by ACE... sigh... these shouldnt be there of course

tbox1911 commented 1 year ago

thanks buddy!

I'll merge that, feel free to come on our discord to chat about mission scripting https://discord.gg/uCRzJ7wauR

I also notice we should add the

ACE Compat - RHS USAF / AFRF Mod

tbox1911 commented 1 year ago

I commit an update about ace filter update and tell me if it's ok