search

tbox1911 / Liberation-RX

ArmA 3 - Liberation RX - Mission
GNU General Public License v3.0
65 stars 62 forks source link

Vehicles going into forever re-arming and can't be placed in a Virtual Garage. #12

Closed Varrkan82 closed 3 years ago

Varrkan82 commented 3 years ago

Tried on F118 Aircraft. It is re-arming too long (once it takes around a 15 minutes) or forever. While re-arming - it is can not be placed to a Virtual Garage.

tbox1911 commented 3 years ago

fixed in a previous release

vehicle must wait 5 minutes to rearm

Varrkan82 commented 3 years ago

fixed in a previous release

vehicle must wait 5 minutes to rearm

Please, could you give me a link to fix. Seems like "previous release" you mean it is a yesterday commit a0a8f664e which I've already tried and it won't work.

tbox1911 commented 3 years ago

it was in Latest commit 529575f 2 days ago

i'll double check rearm veh on my side

Varrkan82 commented 3 years ago

it was in Latest commit 529575f 2 days ago

i'll double check rearm veh on my side

Doesn't see there anything about a 5 minutes. Are you sure?

tbox1911 commented 3 years ago

yep, _cooldown = 20;

I found another bug in this code, cooldown reset too fast I'll fix it

Varrkan82 commented 3 years ago

yep, _cooldown = 20;

I found another bug in this code, cooldown reset too fast I'll fix it

I thought its in a seconds.

tbox1911 commented 3 years ago

it was 20 time sleep 15 (seconds) push a fix for that, plus add message with time remaining ;)

the previous issue only occur if you are close to reammo service (fob, hurron box)

Varrkan82 commented 3 years ago

it was 20 time sleep 15 (seconds) push a fix for that, plus add message with time remaining ;)

the previous issue only occur if you are close to reammo service (fob, hurron box)

This issue fixed. At least the plane can be putted to virtual garage. But re-arming now works in random cases. It could to start rearming and when the counter become the end - it starts to count again and so on. In other cases the re-arming can not start at all and vehicle could be re-armed only when putted into garage.

tbox1911 commented 3 years ago

hmmm, I don't like the actual logic, I'll rewrite this code soon :)

tbox1911 commented 3 years ago

test with the latest commit, should be fine now

Varrkan82 commented 3 years ago

UAV - can not be re-armed just after landing. It still need to be placed to VG, after it removed from VG - it is already re-armed, but the countdown started. On the FOBs - counter start to count if a vehicle (land or air) in the FOB radius. If a vehicle moves away from FOB - the counter periodically appears again till the count is ends.

tbox1911 commented 3 years ago

I update the code to handle theses cases, it should be fine now ! (i hope) please test

add some doc: https://forums.bohemia.net/forums/topic/217186-release-liberation-rx/?do=findComment&comment=3427175

Varrkan82 commented 3 years ago

Fix confirmed