search

tbranyen / backbone.routemanager

Better route management for Backbone.js projects.
MIT License
111 stars 10 forks source link

Safari Strict Mode implementation and route._state #10

Closed there4 closed 8 years ago

there4 commented 10 years ago

It appears that some versions of Safari are having trouble with line 95. It seems that it's throwing an error when setting that property on a string.

I'm considering branching this repo for a fix, but I was curious what the original intent of the _state was, I don't see it in use elsewhere in the code. Is it something can be discarded, or did you have plans for it?

tbranyen commented 10 years ago

This should be fixed in the WIP branch.

there4 commented 10 years ago

I'm looking at line 98 of the wip and still seeing a similar looking line. However, I'll do a quick build of this project with the WIP branch and see how Safari does. The current error message is TypeError: Attempted to assign to readonly property.

I'll close this if the problem is solved in the working branch.

there4 commented 10 years ago

fwiw, I've bumped into a few requirejs troubles with WIP. I'll pick this back up tomorrow. I may just fork this and remove the offending _state line. Seem reasonable?

SBoudrias commented 10 years ago

@there4 If there's a bug, it'd be better to have the fix here.

there4 commented 10 years ago

@SBoudrias - I'd send a PR back, for certain. I'm curious what the plans for _state were.

tbranyen commented 10 years ago

I haven't touched the project in 10 months, no plans to speak of anymore.

there4 commented 10 years ago

I've made a commit to address this issue, and have added another to bring this repo up to Grunt 0.4. Would you be interested in a pull request for it? You can see the commits here.

Their appear to be some unit tests failing around the before/after filters, but I think that was being addressed in the WIP branch. I've left them as-is.

tbranyen commented 10 years ago

Sure thing, if you wanna help out with bringing this plugin current, start PRing away!

there4 commented 10 years ago

Sure, it's been very useful. I'll help with it. I'll send a PR for this bit of it, and then I'll see about getting the backbone in the tests updated and will look at the unit tests.

tbranyen commented 8 years ago

Landed in master via PR