search

tbranyen / backbone.routemanager

Better route management for Backbone.js projects.
MIT License
111 stars 10 forks source link

Remove unused _.state property to solve Safari strict mode issue. Closes #10 #11

Closed there4 closed 10 years ago

there4 commented 10 years ago

This PR includes three commits:

  1. Trailing whitespace
  2. The actual fix
  3. Updating grunt and jshint instrumentation

These together address Issue 10, and update the repo for future work by updating to Grunt 0.4 and fixing the testing harness and build. There are some unit tests still failing around the before/after filters, but I believe they were broken before and were meant to be addressed in the WIP branch. I've left those tests as-is.

I included a npm shrinkwrap file as habit, it's a little chatty in the changelog, sorry for that.

tbranyen commented 10 years ago

The shrinkwrap file is noise for this. Can you drop it from the commit?

tbranyen commented 10 years ago

If you have strong opinions about the shrinkwrap, you can introduce it in a separate PR.

there4 commented 10 years ago

No strong opinions about shrinkwrap, just a local shortcut command here to update and shrinkwrap in one step that is burned into muscle memory from work projects.

there4 commented 10 years ago

Hi @tbranyen - thanks again for this project. I pulled out the shrinkwrap file from last week. Is there anything that you'd like to see in this PR?

tbranyen commented 10 years ago

Did you make more changes, confused now. There's already a bunch of this stuff in the wip branch.

there4 commented 10 years ago

No new changes. That message was a bump of the thread - I've got a release coming up early next week for a project, and wanted to know if this PR could go in. If you need some time or other changes, it's not a problem.

tbranyen commented 10 years ago

Could you re-open this on wip? Sorry for the inconvenience, but merging this into master will make it even harder to get that branch merged in.

there4 commented 10 years ago

Sure, I'll move this to WIP. It could be a few days before I have an opportunity to do that though.

tbranyen commented 10 years ago

No worries take your time, thanks a ton for contributing! :)