search

tbranyen / backbone.routemanager

Better route management for Backbone.js projects.
MIT License
111 stars 10 forks source link

All tests failing #9

Closed wulftone closed 11 years ago

wulftone commented 11 years ago

I cloned this repo and ran the tests... they all fail with Object [object global] has no method 'async' - {}...

What's the status of this project? I'd love to have nested routers and reliable before/after hooks...

Also of note, the router basically works, but after hooks are running before the routes themselves...

tbranyen commented 11 years ago

Check out the wip branch. I got rid of all the filter stuff for now until I can figure out more of the API, but I believe all tests are passing in there.

wulftone commented 11 years ago

Alright, thanks. I'll poke around at other plugins for the before/after stuff then, and see if that'll integrate with the wip branch

tbranyen commented 11 years ago

My friend @boazsender wrote https://github.com/boazsender/backbone.routefilter which does that and should integrate perfectly with routemanager (wip).

wulftone commented 11 years ago

hmm this does work, but unfortunately doesn't fire the base router's hooks when going to a sub-route. Sigh. I may have to resign myself to a single router and a special before/after filter that can do regex per route. Thanks for your help. I look forward to seeing where this project goes!

tbranyen commented 11 years ago

@wulftone oh, you want to reuse a bunch of filters or something across the sub routers?

wulftone commented 11 years ago

Yeah, I thought i'd be nice to have some standardized ways to deal with user permissions and convention-based rendering of views. There's also some data that gets lazily loaded depending on which module is used. Shrug, just trying to DRY things