Added temperature Converter example in Mithril.js

tbreuss / mithril-by-examples

Learn Mithril.js by seeing, reviewing, and running up-to-date code examples

https://mithril-by-examples.js.org

MIT License

10 stars 8 forks source link

Added temperature Converter example in Mithril.js #15

Closed narayand16 closed 3 years ago

narayand16 commented 3 years ago

PR for issue #14

@tbreuss Kindly review and approve

tbreuss commented 3 years ago

Great work, thanks!

I was testing on my machine and noticed, that there is an issue with floating points precision like on this screenshot.

Do you find some time to improve this slightly?

narayand16 commented 3 years ago

Great work, thanks!

I was testing on my machine and noticed, that there is an issue with floating points precision like on this screenshot.

Do you find some time to improve this slightly?

I can do this. Can you specify how many digits precision do we want after decimal point in case of floating numbers ?

tbreuss commented 3 years ago

I can do this. Can you specify how many digits precision do we want after decimal point in case of floating numbers ?

Great!

I would say, one decimal point for this demo is enough.

narayand16 commented 3 years ago

@tbreuss Kindly review and approve the updated PR

tbreuss commented 3 years ago

Thanks. Will test it on my local machine and merge afterwards.

tbreuss commented 3 years ago

Perfect! Thank you.