search

tbreuss / mithril-by-examples

Learn Mithril.js by seeing, reviewing, and running up-to-date code examples
https://mithril-by-examples.js.org
MIT License
10 stars 8 forks source link

Move button for Live Flems Example towards top of the page #48

Closed kevinfiol closed 3 years ago

kevinfiol commented 3 years ago

Hey there :wave: great site, I think this is a great (and updated) alternative to the live examples on the official Mithril site.

One small suggestion I have is moving the Live Example buttons closer to the tops of their respective pages (see screenshot of an example). Not saying it should be under the description, but I definitely think it should be closer to the top of the page. My reasoning is three-fold:

  1. Many users (including me) may want to see what exactly the demo is before I see the code
  2. Flems examples already include the code!
  3. I love the site, but I often find myself scrolling alot just to get to the live example button on each demo

Thoughts welcome.

image

tbreuss commented 3 years ago

@kevinfiol Good idea! Will do this.

I would like to add that the layout is still quite work-in-progress. But anyway, it has no influence on the position of the preview button.

tbreuss commented 3 years ago

Have a version ready with PR #50. It looks like this now:

issue-48-flems-button

I'll merge and release this version later today.

BTW: At the moment the button and the dependencies section can't be splitted, so I moved both to top and styled the dependencies like code examples (using highlight.js).

tbreuss commented 3 years ago

Released with https://github.com/tbreuss/mithril-by-examples/releases/tag/v0.12.0