search

tbrittain / SmbExplorerCompanion

Baseball-Reference style desktop application for Super Mega Baseball 4 franchise playthroughs
MIT License
2 stars 0 forks source link

No SeasonTeamHistory error when importing playoff data #111

Closed DantheChef closed 9 months ago

DantheChef commented 9 months ago

On version 1.0.1, importing regular season data works fine, importing playoff data just throws an error saying that No SeasonTeamHistory record was found. Every time I relaunch and try to import the playoff data, it shows a different team ID. I attached the CSVs.

image image SMB4S1.zip

tbrittain commented 9 months ago

Thanks for attaching the CSVs. I'll look into this ASAP

tbrittain commented 9 months ago

I may have found the source of this bug. Looks like there were some checks in assigning the order of a player to teams that they were a part of during the previous season that did not account for a specific case where the "Current Team" and the "Most Recent Team" were different (as they are identical >99% of the time, and in fact somehow I never encountered this personally, after dozens of seasons of imports), so I am going to make sure this is accounted for. When it came to the playoff data throwing the exception, it was looking for the team ID matching the "Current Team", which didn't exist in the proper state from the regular season import.

I plan on making a hotfix release for this sometime tomorrow. This will require a re-import of your first season data. If that doesn't fix the issue, then we may need to wipe the slate clean and try from a fresh database, but hopefully it doesn't come to that!

tbrittain commented 9 months ago

Just completed the fix. Tested with your regular season and playoff data and it imported successfully. Will be creating a build for this soon. It is a hotfix, but I'll probably bump the minor version since it's a critical fix and I want all downloaded clients to be notified to update