tbrittain / SmbExplorerCompanion

Baseball-Reference style desktop application for Super Mega Baseball 4 franchise playthroughs
MIT License
2 stars 0 forks source link

Just a couple of small issues #118

Closed DantheChef closed 9 months ago

DantheChef commented 9 months ago

This is on Version 1.1.0.

tbrittain commented 9 months ago

Regarding your first point, this is true - I will look into what it'll take to make that a more accurate indicator of the career OPS+. It'll likely just take weighing that number in the average according to the #PA the player had with that OPS+ (which should fix the issue with the few #PA during the postseason being weighed the same)

And regarding your second point, this is something I plan to fix with the next release: #50 . I had some concerns with how to sort by those numbers for the career screen, since it's easier to do so on the season screen when we can just omit the unqualified players from that sort order. I'll need to think on the best way to do this for the career

tbrittain commented 9 months ago

Based on the way that the career data is being pulled, it should correct the career OPS+ value on the player page, as well as the career batting grids. I'll make sure this is corrected for ERA- (which I need to rename to ERA+) as well

tbrittain commented 9 months ago

Closing this for now as the OPS+/ERA+/FIP+ career average will have been fixed in v1.1.2, releasing shortly