search

tbrittain / SmbExplorerCompanion

Baseball-Reference style desktop application for Super Mega Baseball 4 franchise playthroughs
MIT License
2 stars 0 forks source link

Ability to associate the same player from different franchise runs to the same player in this app #8

Closed tbrittain closed 1 year ago

tbrittain commented 1 year ago

Within the game, if we export a franchise snapshot to a new league and create a franchise from that, it is possible that the players in the new franchise will have different baseball player GUIDs than the ones in the original franchise. We need to architect the database in a way that allows us to associate the new franchise player with the old franchise player

Additionally, we need to think about the season numbers, as what will most likely happen in the new franchise is that the calculated season numbers do not roll over from the previous franchise. Easiest solution here would be to have users replace that column in the CSV, or to have a configuration within this app that asks for the season number (if not provided). It might be beneficial in SMB Explorer to export the season ID itself for validation purposes, rather than relying on the calculated season number

tbrittain commented 1 year ago

One thing about this, the default matching behavior should also attempt to check that the player being checked has a SeasonPlayerHistory record with the previous season to that being added (if exists). This will prevent players who have retired long ago being associated with a new player (false positive, since it will definitely be a new player with the same top-level properties)

tbrittain commented 1 year ago

This was completed on #88