search

tbroadley / spellchecker-cli

A command-line tool for spellchecking files.
MIT License
119 stars 16 forks source link

Create a dictionary of tech words #105

Closed a2937 closed 1 year ago

a2937 commented 1 year ago

As part of submitting a pull request, please:

[ ] Attempt to add tests for your change. If you're having difficulty, feel free to open the PR and ask for help. [X] Add a line to the Unreleased section of CHANGELOG.md describing your change (and crediting yourself if you'd like!)

I attempted to add as many technology related words that I could find. If there are any issues or typos or words that shouldn't be there be sure to let me know and I will remove extra words.

Also officially on the record; there is an assertion failure when running the builtin tests. However upon closer inspection; it appears to be a part of default behavior.

Closes #104

a2937 commented 1 year ago

Thank you. Those extra words were added completely by accident.

a2937 commented 1 year ago

Mainly because I didn't use two dictionaries at once when making my initial list to sort through.

a2937 commented 1 year ago

It's not a warning. It's a fail.

Assertion error of retext-repeated-words

tbroadley commented 1 year ago

Ah yes, I've seen that test failure too. Can't quite recall why it happens off the top of my head. https://github.com/tbroadley/spellchecker-cli/issues/106

a2937 commented 1 year ago

My best guess judging by the following lines of code:

https://github.com/tbroadley/spellchecker-cli/blob/f79e66bbc8e6797c93489d5c209ea825285f06aa/test/cli-test.ts#L344-L351

is that previously this code checked for a standard output message because that's what the plugin used to do. But now it throws an actual error.