Closed declanvk closed 4 years ago
Thank you for the PR! It looks good. I have a couple of requests if you don't mind.
I'm wondering if it's possible to write a test for this flag. Maybe by adding a .gitignore
to test/fixtures
, then writing a test that creates a gitignored file in that directory and runs node index.js
on it. test/cli-test.js
contains some similar tests.
Also, I just created a pull request template. Would you mind following the last three steps in that file?
I added the documentation to the CHANGELOG and README, plus the tests that include a gitignore'd file. Let me know if there is anything else I can include.
Thanks for making those changes! I'll release a new version right away.
Description
Add new CLI option as a boolean flag that will disable using the
.gitignore
file to filter out files from spellcheckingMotivation
I'm interested in using
spellchecker-cli
on artifacts produced by my build process, however the hardcoded{ gitignore: true }
prevents that.Testing
Manual testing in the
spellchecker-cli
repo, I ran:Related