search

tbroyer / gwt-maven-archetypes

Apache License 2.0
152 stars 39 forks source link

fix server start by adding jetty-maven-plugin as build plugin #18

Closed a14n closed 12 years ago

a14n commented 12 years ago

jetty-maven-plugin was only present in pluginManagement parts. When launching cd *-server && mvn jetty:start -Ddev, the following error occured :

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] The plugin 'org.apache.maven.plugins:maven-jetty-plugin' does not exist or no valid version could be found

I hesitated between adding jetty-maven-plugin as general build plugin or only in dev profile. I finally choose the first option which additionnally provides a way to start server in a mode where server uses *-shared.jar and *-client.war dependencies previously installed with a mvn clean install in root directory.

What do you think?

tbroyer commented 12 years ago

Could it be due to your use of Maven 2? It works with Maven 3.0.3.

I'd rather require Maven 3 than make a change only to content the oldish Maven 2 (it will be 3 years old on August 11th!) I'll have to test with various versions though to determine the one to put in prerequisites, or maybe simply require the latest one (3.0.4; and upgrade myself to that version, which I should do anyway according to the release notes).

a14n commented 12 years ago

Oops, I was using a bad ubuntu package (maven2 instead of maven). That's why I used 2.2.1 version. After switching, mvn jetty:start -Ddev works fine with Maven 3.0.4.

+1 for requiring the latest version. With that, you can remove https://github.com/tbroyer/gwt-maven-archetypes#compatibility

Thanks and sorry for disturbing.