Use the gwt-version property for the dtd declaration inside gwt.xml files

[nmorel]

Hello,

Here is a small patch to use the gwt-version property for the dtd instead of the hard-coded 2.4.0 version.

[buildhive]

Thomas Broyer » gwt-maven-archetypes #13 SUCCESS This pull request looks good (what's this?)

[tbroyer]

I'd actually be tempted to remove the DOCTYPEs altogether, what do you think?

(while I generally agree with the change –thanks–, it will break for self-built GWT distros –which you'd likely version as 2.5.0-mycompany-r11161-patched or similar– or when/iff GWT starts to publish snapshots)

[nmorel]

Ah right, I forgot about the self-build distro.

If we keep the hard-coded dtd version, it works for any distro but it's not sync to the gwt version used.

If we remove them, no one will have the dtd, validation, auto-completion... People new to GWT would probably prefer to have it as they are not using a self-build distro.

If we keep the doctype and use the gwt-version property, people using self-build distro will just get a warning by their IDE (I think there is one too if the doctype declaration is missing anyway).

Other suggestions :

• Comment the doctype instead of removing it. Those who want to use it can uncomment it instead of looking for the correct doctype themselves.
• Add a property to define the version of the dtd to use (default to gwt-version). Might be overkill, there is already a lot of properties

[tbroyer]

OK, convinced. Power-users (using custom-built distros) will just have one line to delete or update.