fix CTRL-C on Windows by replacing out-of-date plexus-utils command line stuff with ProcessBuilder->inheritIO()

tbroyer / gwt-maven-plugin

Starting fresh on building GWT projects with Maven

https://tbroyer.github.io/gwt-maven-plugin/

Apache License 2.0

167 stars 39 forks source link

fix CTRL-C on Windows by replacing out-of-date plexus-utils command line stuff with ProcessBuilder->inheritIO() #125

Closed jjYBdx4IL closed 2 years ago

jjYBdx4IL commented 5 years ago

CTRL-C now works properly on WIndows and Linux. I threw out the entire ancient plexus-utils command line handling für the Codeserver and replaced it with a quick and simple ProcessBuilder. It's not as colorful now and it doesn't get directed through a logger, but it also doesn't require a shutdown hook now (which wasn't working anyways on Windows).

tbroyer commented 2 years ago

The bug is in plexus-utils, which is used by many Maven plugins (including Surefire and the maven-compiler-plugin ‼). There's no reason that plugins each implement their own command-line handling, this should be fixed upstream.