search

tbruyelle / RxPermissions

Android runtime permissions powered by RxJava2
Apache License 2.0
10.48k stars 1.31k forks source link

Lies in the README (no constructor with activity) #243

Open Grohden opened 6 years ago

Grohden commented 6 years ago

The readme says:

new RxPermissions(this) the this parameter can be an Activity or a Fragment.

but i actually can't use an activity with the current constructors..or can i?

I think this commit removed the activity constructors.. so what should i do now?

epool commented 6 years ago

@Grohden you need to use at least a FragmentActivity or some of its children

Grohden commented 6 years ago

@epool luckly our activity hierarchy had a FragmentActivity in it at some point, so i could solve this error (i updated this lib yesterday, it was using context as argument before)... But this isn't bad? removing the support of the "normal" activity does not break some projects?

Flo354 commented 6 years ago

It clearly broke my project. I updated from 0.9.5 to 0.10.2 and was surprised to see that I wasn't able anymore to use an activity.

Why such a limitation?