tbruyelle / RxPermissions

Android runtime permissions powered by RxJava2
Apache License 2.0
10.48k stars 1.31k forks source link

findRxPermissionsFragment may cause ClassCastException #282

Open laomo opened 5 years ago

laomo commented 5 years ago

Use getSimpleName() as tag for fragment is danger after proguard, and I ran into it. Of course, I change my fragment tag name,but I think a library should avoid this.

https://github.com/tbruyelle/RxPermissions/blob/master/lib/src/main/java/com/tbruyelle/rxpermissions2/RxPermissions.java#L83

Reference: https://medium.com/@elye.project/the-danger-of-using-class-getsimplename-as-tag-for-fragment-5cdf3a35bfe2