tbruyelle / RxPermissions

Android runtime permissions powered by RxJava2
Apache License 2.0
10.48k stars 1.31k forks source link

Add 'Issue template' and 'Bug report template' #314

Closed mrArtCore closed 4 years ago

mrArtCore commented 4 years ago

Add 'bug report' and 'feature' templates. From now users who want to open a new issue will be asked to fill down some template in order to give a comprehensive information about some bug or another code defect. Also, the user will be asked first to chose one of 2 options

mrArtCore commented 4 years ago

Hi @tbruyelle How are you? I've created bug and feature templates for new issues. If somebody wants to open a new Issue he/she must fill down issue template. I create this because I've been seeing so many ugly issue reports here. And I feel guilty about doing it only now. I've experimented with this about a year ago and just had no time to do it at once then. But maybe it's not too late to create such PR? Current flow will be:

My suggestion force the community to create well-described issues so that it could be reproduced and fixed afterward. Sometimes I feel that I can fix something, but play with reproducing things is not what I want to do. I think you know what I mean.

Note: Yes, I've tested it in my forked master and it's worked as supposed so. But I wasn't able to test it before merging feature branch in master (in the forked repository). So if you want to play with it and check how it works, might be you should fork to the private repo in another GitHub account ??? Actually I don't know how to test it if you're repo owner =\

mrArtCore commented 4 years ago

@epool Hi! Could you review my PR, please?

mrArtCore commented 4 years ago

@tbruyelle Hello! Hope you're going well! Seems that we can't reach out @epool quite a long time since PR was opened.

How about merging this without his approval?

tbruyelle commented 4 years ago

Yes let's merge it.