feat: Migrate to RxJava 3 and RxBinding 4 fixes #317

tbruyelle / RxPermissions

Android runtime permissions powered by RxJava2

Apache License 2.0

10.49k stars 1.31k forks source link

feat: Migrate to RxJava 3 and RxBinding 4 fixes #317 #326

Closed galuszkak closed 4 years ago

galuszkak commented 4 years ago

Hi @tbruyelle and @epool ,

I've prepared here migration to RxJava 3 and move sample to use RxBinding 4 that also uses RxJava 3.

Tests are passing so I think this PR should be OK. This should fix #317

Thanks!

tbruyelle commented 4 years ago

Looks cleaner than #320 which embeds more changes. Good to me, WDYT @epool ?

galuszkak commented 4 years ago

@epool answering your question on compatibility with RxJava 2 if anyone would need their Observable to be V2 not V3 they can use bridge library called RxJavaBridge which is available here: https://github.com/akarnokd/RxJavaBridge

tbruyelle commented 4 years ago

Thx @epool for the review Thx @galuszkak for the clear PR !