search

tbsdtv / linux_media

TBS linux open source drivers
https://github.com/tbsdtv/linux_media/wiki
Other
174 stars 80 forks source link

get_current_lrr reads invalid memory #231

Open wphilips opened 3 years ago

wphilips commented 3 years ago

get_current_llr reads outside of the array bounds of dvbs2_modcode_for_llr_x100 and dvbs1_modcode_for_llr_x100.

The if tests allow readin an element past the end of the arrays. I have seen tis actually happening on a dvbs1 transponder. Also, it can happen that the code does not set *current_llr at all, in which case it will use the last stored value, which can also be wrong.

wphilips commented 3 years ago

llr_patch.txt Patch for this issue