search

tbsdtv / linux_media

TBS linux open source drivers
https://github.com/tbsdtv/linux_media/wiki
Other
169 stars 79 forks source link

tbsecp3: get rid of pci_alloc_consistent usage #281

Closed CounterPillow closed 2 years ago

CounterPillow commented 2 years ago

pci_alloc_consistent is a legacy function that allocates GFP_ATOMIC memory, the driver seemingly doesn't need this and it breaks probing on some hosts (notably the PINE64 Quartz64 Model A).

Replace this with dma_alloc_coherent using GFP_KERNEL memory, which is what is preferred for generally all kernel allocations.

I don't have the TV tuner card to test this with, but someone who does tested this patch for me and confirmed it to have fixed their issue.

Also please for the love of everything that is holy, upstream your drivers so these things can be corrected tree-wide.

crazycat69 commented 2 years ago

a28bc18ab10718df51b740843423f8db21833138