search

tbuchok / vast-xml

A Node module for creating real-time VAST XML responses.
48 stars 27 forks source link

AdTitle for wrapper ad? #34

Open wroberts15 opened 9 years ago

wroberts15 commented 9 years ago

Hey just wondering if you think that having the AdTitle in the wrapper ads would be a good addition?

Again, it's just something small I noticed- no AdTitle is generated in a wrapper ad even if specified...

tbuchok commented 9 years ago

up for a pull request on this? would love to see your contributions to the codebase after all these helpful comments!

wroberts15 commented 9 years ago

Yeah, sounds good to me. Doubt it'll be much, but I'll do that hopefully by tomorrow.

wroberts15 commented 7 years ago

Realized that I may need to make some more changes to this module in the upcoming weeks. Did you want to reject this pull request? It works for me locally, if you did want to include this

denes16 commented 3 years ago

Is this repo still alive?

tbuchok commented 3 years ago

hi @denes16 - i haven't put any time into this repo in several years. no longer working in the video world. is there something you're looking for assistance on?

denes16 commented 3 years ago

hi @denes16 - i haven't put any time into this repo in several years. no longer working in the video world. is there something you're looking for assistance on?

No thanks, but your repo is very useful, and now im using it in a real project, thanks. Its working good, thanks