search

tbuchok / vast-xml

A Node module for creating real-time VAST XML responses.
48 stars 27 forks source link

add creative support w/out duration for wrapper tags #39

Open pbwilmot opened 8 years ago

pbwilmot commented 8 years ago

Goal of this PR : include the ability to add creatives with tracking events but not set a duration or mediafile for wrapper tags

excerpt from spec : 2.4.1.4 Linear Creative Format within a Wrapper The most important difference between a Wrapper Linear creative and an Inline one is that a Wrapper Linear creative is absent of any media files. The only elements allowed in a Wrapper Linear creative are VideoClicks and TrackingEvents. These tracking elements enable tracking data to be collected at the Wrapper for any events that occur in the Inline Linear creative that is served following the Wrapper.

pbwilmot commented 8 years ago

you also might want to update to current versions of 'tap' and 'libxmljs' since the versions that are used in this project are pretty outdated and wont build anymore.

tbuchok commented 8 years ago

@pbwilmot thanks for the clear PR and helpful feedback! i'm a bit busy this morning but will take a look and merge / npm publish within the next day or so. are you blocked meantime?

you mentioned updating the deps, good call. i suppose it might be time to bump the major version on this and set 2.x.x as vengine: 4.^ only, yea?

thanks again and i'll be in touch as we make progress on this.

tbuchok commented 8 years ago

@pbwilmot one thing i'm noticing in this is that the test file was updated, but no new tests were added. are you able to add some tests to handle this specific scenario?

if not, i can add merge this and then add them before publishing to npm.