search

tburrows13 / LunarLandings

GNU General Public License v3.0
9 stars 7 forks source link

Add `launch when filled` option to the rocket silo #9

Open Quezler opened 1 month ago

Quezler commented 1 month ago

This pull request adds a launch when filled option to cargo rockets which make them launch when no empty slots are left, this feels very necessary when doing mixed rocket launches which is very likely when people install aai signal transmission for some cross surface circuitry.

Just like space exploration it has the caveat of leaving slots partially empty, the thought to include an "inactivity counter" did cross my mind but it would need to be stored in a global and i wanted to keep this pull request relatively simple.

tburrows13 commented 1 month ago

Looks ok, but you’re going to have to pick a new name for this because I’m pretty sure no one is going to see any difference in meaning between “filled” and “full”.

Also I’d rather if you didn’t update the info.json version in the PR.