search

tburry / pquery

A jQuery like html dom parser written php.
GNU Lesser General Public License v2.1
135 stars 25 forks source link

some improvements #16

Open to0oner opened 6 years ago

to0oner commented 6 years ago

The most important commit 88bd078 give the parser a big performance boost.

I've tested this with PHP 7.1.12 on some html files (size ~5kb), the parsing time decreases from ~4 seconds to under 0.1 seconds.

robations commented 6 years ago

LGTM — 88bd078 took a 2 min parsing operation down to 10 seconds in one test.

But RIP tburry/pquery :)

robations commented 6 years ago

Note there is some inconsistency between tabs and spaces within the source code, there is already inconsistency between files, but one line in the PR adds spaces into a file that has tabs.