Partial fix for your issue #4

tbuser / thingiview.js

Javascript 3D Model Viewer

http://replimat.com/thingiview/examples

GNU Lesser General Public License v3.0

398 stars 110 forks source link

Closed cbiffle closed 13 years ago

cbiffle commented 13 years ago

In my analysis of https://github.com/tbuser/thingiview.js/issues#issue/4 I noted one bogus model that had "solid" in its first line, even though it was binary.

This fixes such models, by making the binary-vs.-ASCII decision slightly more complicated.

cbiffle commented 13 years ago

Since I originally wrote, I've made a couple more changes:

I removed some unused data structures.
I disabled the 'large object' warnings, which in a modern browser (Chrome, Firefox, nightly builds of Safari) usually show up on top of the rendered object...making them kind of redundant.

Cherrypick as you see fit.

cbiffle commented 13 years ago

These two additional commits fix the cases Marty reported this morning.