search

tc / paypal_adaptive

Light wrapper for Paypal's Adaptive Payment API
MIT License
252 stars 97 forks source link

Support for ruby 2.0 #75

Open jims3ne1 opened 11 years ago

jims3ne1 commented 11 years ago

Is this compatible with ruby 2.0? We tested it, it seems fine but just wondering if there's anything we should be aware of.

tc commented 11 years ago

I have not tested it myself but if anyone else is using it with 2.0, please comment here. On Jul 8, 2013 4:53 AM, "jimbocortes" notifications@github.com wrote:

Is this compatible with ruby 2.0. We tested it, it seems fine but just wondering if there's anything we should be aware of.

— Reply to this email directly or view it on GitHubhttps://github.com/tc/paypal_adaptive/issues/75 .

rchekaluk commented 10 years ago

I have found that paypal_adaptive 0.3.6 send_back fails to validate a Paypal IPN under ruby-2.0.0-p353, yet validates just fine under ruby-1.9.3-p484.

Don't know if it's relevant or not but in another gem, I encountered this Net::HTTP incompatibility (and successfully utilized the monkey patch); there could be other Net::HTTP changes in ruby 2.0 that are affecting paypal_adaptive.

Update: It's possible that this issue is limited to Heroku apps.

rchekaluk commented 10 years ago

Under ruby-2.0.0-p353, I found that the PaypalAdaptive::Request.preapproval POST response is binary data; since this cannot be parsed as JSON, preapproval returns an error message of "Response is not in JSON format."