search

tc39 / Function-prototype-toString-revision

:fishing_pole_and_fish: ECMA-262 proposal to update Function.prototype.toString
https://tc39.github.io/Function-prototype-toString-revision
26 stars 10 forks source link

CreateDynamicFunction lacks line break after opening brace #12

Closed bterlson closed 8 years ago

bterlson commented 8 years ago

All implementations today add a line break after the opening bracket, but this specification says we should not include it. Was this deliberate? I think the line break aids in readability but I care only a tiny amount.

michaelficarra commented 8 years ago

It was deliberate because there is no need for it. Also, I don't think adding it matters for compatibility since engines differ significantly here.

michaelficarra commented 8 years ago

Closing until I receive further feedback.

domenic commented 8 years ago

I agree that it aids readability, and the fact that all engines today include it is a good indication it should stay.

claudepache commented 8 years ago

I've noticed a more peculiar issue: a spurious line break is currently inserted before the closing parenthesis at the end of the arguments list. I've considered that as just a typo, that line break should appear after the opening brace. See #13 (that I opened before noticing the present issue).