Closed gesa closed 2 months ago
Now that I see the "Field / Module" test, I don't actually like how it looks.
What do people think of the following:
<emu-table id="table-module-graph-cycle-async-fields-7" caption="Module fields after module _C_ finishes with an error">
<table>
<col>
<col span="2"></colgroup>
<thead>
<tr>
<td></td>
<th colspan="2" scope="colgroup">Module</th>
</tr>
<tr>
<td></td>
<th scope="col">_A_</th>
<th scope="col">_C_</th>
</tr>
</thead>
<tr>
<th scope="row">[[DFSIndex]]</th>
<td>0</td>
<td>3</td>
</tr>
<tr>
<th scope="row">[[DFSAncestorIndex]]</th>
<td>0</td>
<td>0</td>
</tr>
<tr>
<th scope="row">[[Status]]</th>
<td>~evaluated~</td>
<td>~evaluated~</td>
</tr>
<tr>
<th scope="row">[[AsyncEvaluation]]</th>
<td>*true*</td>
<td>*true*</td>
</tr>
<tr>
<th scope="row">[[AsyncParentModules]]</th>
<td>« »</td>
<td>« _A_ »</td>
</tr>
<tr>
<th scope="row">[[PendingAsyncDependencies]]</th>
<td>1 (_B_)</td>
<th>0</th>
</tr>
<tr>
<th scope="row">[[EvaluationError]]</th>
<td>~empty~</td>
<td>_C_'s evaluation error</td>
</tr>
</table>
</emu-table>
@syg's suggestion works for me. Alternatively, something like this:
Fields Modules | A | B |
---|---|---|
[[DFSIndex]] | data1 | data2 |
[[DFSAncestorIndex]] | data3 | data4 |
@bakkot's snippet is my preference.
@bakkot I'm fine with something like that, but the padding needs to be adjusted so we don't have the labels shoved in the corners.
Added the slashed corner header cell. It looks like this:
Looks great.
@syg Can you take a look at the screenshot I posted and let us know if this is ready to merge?
This provides improved readability while maintaining the same information.
I will also be making these changes to the ever-so-slightly different 2024 branch, but i will likely not open a pr on that branch as that work’s mostly for me.