Correct definition of JSC "runtime" object

tc39 / eshost

A uniform wrapper around a multitude of ECMAScript hosts. CLI: https://github.com/bterlson/eshost-cli

Other

142 stars 36 forks source link

Correct definition of JSC "runtime" object #113

Closed jugglinmike closed 3 years ago

jugglinmike commented 3 years ago

A recent commit [1] regressed support for JavaScriptCore by changing the way the "runtime" object is defined for that engine. Restore the intended behavior and add an automated test.

[1] 4e9c3ee9b2c8cb1578e5bd9af18a028890b35b4d

The CI system is not currently configured to validate this change (or any other change) in JavaScriptCore. See gh-112 for that.

The regression has been observed in results published to test262.report: https://github.com/bocoup/test262-report-issue-tracker/issues/28

Constellation commented 3 years ago

@rwaldron Can you update test262-harness too? https://github.com/bterlson/test262-harness

jugglinmike commented 3 years ago

The test262-harness project currently depends on eshost with the version specifier ^8.0.0. Since this bug fix was released in eshost version 8.1.0, consumers of test262-harness should receive it automatically upon installing the dependencies.