search

tc39 / eshost

A uniform wrapper around a multitude of ECMAScript hosts. CLI: https://github.com/bterlson/eshost-cli
Other
142 stars 36 forks source link

Potential regression in JavaScriptCore support #114

Open jugglinmike opened 3 years ago

jugglinmike commented 3 years ago

A recent change to the JavaScriptCore "agent" may have regressed JSC support. Commit 4e9c3ee9b2c8cb1578e5bd9af18a028890b35b4d (which was first released in eshost version 8.0.0) includes the following modification

-  let env = Object.assign({}, process.env, { DYLD_FRAMEWORK_PATH });
   this.cpOptions = {
-    env
+    ...process.env,
+    DYLD_FRAMEWORK_PATH
   };
 }

Prior to that change, the object assigned to this.cpOptions had a single property, and that property was named env. The change caused this.cpOptions to become the value which was previously defined as the env property. As far as I can tell, none of the references to the property were updated to reflect this change.

I have not observed any regressions related to this change since the release of version 8.0.0.