search

tc39 / eshost

A uniform wrapper around a multitude of ECMAScript hosts. CLI: https://github.com/bterlson/eshost-cli
Other
142 stars 36 forks source link

Avoid timeout bug in Socket.io #22

Closed jugglinmike closed 7 years ago

jugglinmike commented 7 years ago

When a Socket.io server with active connections is destroyed, it may fail to clear long-running internal timers. The process will not exit while such timers are active, causing significant delays between server destruction and process termination.

Re-order the sequence of actions in the WebDriverAgent's destroy method to first end the browsing session (allowing all Socket.io-related timers to be cleared) and then destroy the Socket.io server.

rwaldron commented 7 years ago

@bterlson ping

rwaldron commented 7 years ago

I forgot that I had a pending invite to this repo