search

tc39 / eshost

A uniform wrapper around a multitude of ECMAScript hosts. CLI: https://github.com/bterlson/eshost-cli
Other
142 stars 36 forks source link

NodeAgent: Execute scripts in dedicated VM #28

Closed jugglinmike closed 7 years ago

jugglinmike commented 7 years ago

@bterlson I've added a test for cross-realm interactions as per your request in IRC. Note that it does not assert error names. This vagueness is intentional because not all hosts currently report the correct error, but that's a detail for Test262 to validate.

jugglinmike commented 7 years ago

Thanks for the review, @rwaldron. It should be all set

bterlson commented 7 years ago

whoops, I conflicted this one with #30. @jugglinmike can you rebase?

jugglinmike commented 7 years ago

@bterlson Sure. Rebased on master, resolving conflicts and fixing up fixup commits.

(For posterity, the original version of this branch is available here).

rwaldron commented 7 years ago

With the conflicts resolved, I will assume @bterlson is 👍

jugglinmike commented 7 years ago

Thank you both!