Use only pre-es6 syntax in the `node` runtime

tc39 / eshost

A uniform wrapper around a multitude of ECMAScript hosts. CLI: https://github.com/bterlson/eshost-cli

Other

142 stars 36 forks source link

Use only pre-es6 syntax in the `node` runtime #99

Closed weswigham closed 4 years ago

weswigham commented 4 years ago

To allow the runtime to be used with very old versions of node that predate es6 support (like node 0.10). It used to be like this before https://github.com/bterlson/eshost/pull/41 and https://github.com/bterlson/eshost/pull/28 which were by and large unrelated to explicitly dropping support for older hosts in the test runtime, seems like; so it'd be nice to still support them, IMO.

rwaldron commented 4 years ago

I'm going to accept this and do a release of eshost v6.x.x, but then I'm going end support for non-LTS versions of Node.js. That change will be documented and come with a v7 release.

weswigham commented 4 years ago

Sorry, but uhhh on secondary inspection, I may have kinda missed a location where a shorthand needed to be expanded out when I actually made this PR (that's what I get for using the web UI) - namely here. Would you wanna publish another v6 release with a small patch to finish fixing the problem? This time I can confirm that that's the only thing left from testing locally, at least.