search

tc39 / proposal-class-fields

Orthogonally-informed combination of public and private fields proposals
https://arai-a.github.io/ecma262-compare/?pr=1668
1.72k stars 113 forks source link

Typo on spec.html #157

Closed ENvironmentSet closed 6 years ago

ENvironmentSet commented 6 years ago

https://github.com/tc39/proposal-class-fields/blob/1e3f638d91cd300bd6d01d5b3c0aec194df1ebf5/spec.html#L376

I think this line should be </emu-alg>. because line 377(next line) closes parent tag of <emu-alg>.

https://github.com/tc39/proposal-class-fields/blob/1e3f638d91cd300bd6d01d5b3c0aec194df1ebf5/spec.html#L377

feysalikbal commented 6 years ago

Here is the PR #164 to fix the typo.

ENvironmentSet commented 6 years ago

Cool :) Now I can focus on other job :) thank you for to work instead of me !

littledan commented 6 years ago

Great teamwork! Thanks.

feysalikbal commented 6 years ago

Thanks :) I am open to contribute more.

littledan commented 6 years ago

@feysalikbal The biggest thing that I've been wanting to do but haven't gotten around to has been to create a combined piece of specification text covering this proposal, static class features, and private methods. The combined version would be more readable than the current three separate documents. Would you be interested in that?

ENvironmentSet commented 6 years ago

@feysalikbal

I found another one. if you interest in doing things that @littledan requested, I will post it as issue for you.

Oops, I misunderstood what littledan said. sorry, this issue is not related with it. but this issue still needs someone to fix it.