search

tc39 / proposal-class-fields

Orthogonally-informed combination of public and private fields proposals
https://arai-a.github.io/ecma262-compare/?pr=1668
1.72k stars 113 forks source link

Reorder strict=true and privateScope to follow FunctionCreate signature #282

Closed kevinkassimo closed 4 years ago

kevinkassimo commented 4 years ago

Seems that the 2 are flipped in order. According to the spec:

3.9.4 FunctionCreate ( kind, ParameterList, Body, Scope, PrivateScope, Strict [ , prototype ] )

nicolo-ribaudo commented 4 years ago

After https://github.com/tc39/ecma262/pull/1562, all this part of the proposed text spec must be rewritten.

kevinkassimo commented 4 years ago

@nicolo-ribaudo Is this proposal based on es6 spec or master of ecma262? Since I see quite a few es6num markers and spec in this repo uses steps exactly matching the former, which does include FunctionCreate instead of OrdinaryFunctionCreate

littledan commented 4 years ago

@kevinkassimo This is based on the master of ecma262, though it's likely it got a bit stale. I'd welcome PRs to rebase.

ljharb commented 4 years ago

If this repo is updated, please be sure to ensure that https://github.com/tc39/ecma262/pull/1655, https://github.com/tc39/ecma262/pull/1667, and https://github.com/tc39/ecma262/pull/1668 are all updated as well.

kevinkassimo commented 4 years ago

In that case I would close this PR. (I actually made an attempt to update fully, but there are still quite a few mismatching parts and I currently do not have the time to work on unfortunately...)