tc39 / proposal-defer-import-eval

A proposal for introducing a way to defer evaluate of a module
https://tc39.es/proposal-defer-import-eval
MIT License
208 stars 12 forks source link

Stage 2.7 roadmap #24

Open nicolo-ribaudo opened 11 months ago

nicolo-ribaudo commented 11 months ago

Before Stage 3, we still need to investigate multiple aspects of the proposal. Each topic should be discussed in its own issue, but I'm writing all of them here to keep track of the progress.


TODOs


Reviews

nicolo-ribaudo commented 4 months ago

I was planning on proposing this for Stage 2.7 at the April meeting, and I remembered just a few days ago (because I was pinged for a review) that editor reviews are needed for Stage 2.7 and not for Stage 3.

The spec text at https://tc39.es/proposal-defer-import-eval/ is complete and is what I plan to propose. Regarding the open PRs in this repo:

I know that this ping is coming way too late, so I understand if it's impossible for you to take a look before plenary :)

guybedford commented 4 months ago

My review can be considered complete after https://github.com/tc39/proposal-defer-import-eval/issues/38 is resolved, with the PR in https://github.com/tc39/proposal-defer-import-eval/pull/39 and https://github.com/tc39/proposal-defer-import-eval/pull/35 already landed. The implementation approach is really neat, nice work.

dminor commented 4 months ago

This looks good to me, thank you for the good work here.

nicolo-ribaudo commented 3 months ago

@bakkot @michaelficarra @syg I'm planning to re-propose this for 2.7 at the next meeting, I would appreciate if you could find some time to review the spec text.

If you already took a look at this last time, there have been two PRs to handle a bug that @guybedford found with re-entrancy and top-level errors: https://github.com/tc39/proposal-defer-import-eval/pull/39 and https://github.com/tc39/proposal-defer-import-eval/pull/43

dminor commented 2 months ago

I've had another look, I think this is good for 2.7.

michaelficarra commented 2 months ago

@nicolo-ribaudo Why do you use an early error to restrict ImportClause in ImportDeclaration to NameSpaceImport when defer is present? Why not just add an alternative to ImportDeclaration?

michaelficarra commented 2 months ago

@nicolo-ribaudo There's also a misspelling of [[Specifer]] that occurs multiple times.

edit: I'll just turn this into a review feedback comment.