search

tc39 / proposal-explicit-resource-management

ECMAScript Explicit Resource Management
https://arai-a.github.io/ecma262-compare/?pr=3000
BSD 3-Clause "New" or "Revised" License
725 stars 29 forks source link

Add missing .prototype property entries for DisposableStack/AsyncDisposableStack #167

Closed rbuckton closed 12 months ago

rbuckton commented 1 year ago

This adds entries that were missing that are necessary to describe the behavior of the .prototype property on the DisposableStack and AsyncDisposableStack constructors.

cc: @tc39/ecma262-editors

github-actions[bot] commented 1 year ago

A preview of this PR can be found at https://tc39.es/proposal-explicit-resource-management/pr/167.

rbuckton commented 1 year ago

Quick clarification: Would this be considered an editorial change since there was no obvious intention to explicitly exclude prototype here, or a needs consensus PR? Im happy to hold off on merging if this needs consensus, even if only perfunctorily.

ljharb commented 1 year ago

Seems like it's normative, but an obvious oversight - so i'd say you can either wait til plenary, or, just merge it and simply notify plenary (obv with the ability to revert it if there were pushback)

rbuckton commented 12 months ago

This was approved by consensus at the July, 2023 TC39 Plenary, but still needs reviews from the editors and reviewers before I can merge.

@waldemarhorwat, @syg, @michaelficarra, @bakkot: can you please review?