tc39 / proposal-function-implementation-hiding

JavaScript language proposal: function implementation hiding
https://ci.tc39.es/preview/tc39/ecma262/pull/1739
MIT License
98 stars 7 forks source link

combine F.p.toString and E.p.stack censorship proposals #17

Closed michaelficarra closed 5 years ago

michaelficarra commented 5 years ago

This PR is a WIP right now. I'm updating section by section as I get time to work on it. I've done the introduction and problem statement so far. I'll add a comment when it's ready for a full review, but feel free to start reviewing now.

Fixes #8.

michaelficarra commented 5 years ago

Okay @domenic @ljharb @phoddie this should be ready for review now.

domenic commented 5 years ago

I've pushed minor review tweaks. I'll also work on updating the spec to at least use the new name.

I'd like to merge this ASAP so I can work on the other outstanding issues in the repository, but I want to make sure you're OK with the changes I made before doing so. Let me know!

michaelficarra commented 5 years ago

LGTM

domenic commented 5 years ago

@michaelficarra do you want to be a co-champion?

michaelficarra commented 5 years ago

@domenic Yes, that seems appropriate.