search

tc39 / proposal-function-implementation-hiding

JavaScript language proposal: function implementation hiding
https://ci.tc39.es/preview/tc39/ecma262/pull/1739
MIT License
98 stars 7 forks source link

shouldn't this proposal be dependent of the error stacks proposal? #26

Closed ghermeto closed 5 years ago

ghermeto commented 5 years ago

Shouldn't this wait for the Error.prototype.stack to be standardized?

https://github.com/tc39/proposal-error-stacks

ljharb commented 5 years ago

See #8.

michaelficarra commented 5 years ago

I think we can kind of do a two-phase approach with the stack omission portion of this proposal. We can at first add a hand-wavey normative note that requires the marked function not to appear in any stack traces made available to the JavaScript program. When the error stacks proposal makes progress, we can phrase this restriction more formally.

@domenic Thoughts?

ljharb commented 5 years ago

That was the conclusion that was merged here

domenic commented 5 years ago

Yep, exactly my thoughts, with my past self's code to back me up.