search

tc39 / proposal-global

ECMAScript Proposal, specs, and reference implementation for `global`
http://tc39.github.io/proposal-global/
MIT License
349 stars 18 forks source link

Path to Stage 4! #12

Closed ljharb closed 4 years ago

ljharb commented 8 years ago

Stage 4

chicoxyzzy commented 7 years ago

Chrome started implementing global behind a flag https://bugs.chromium.org/p/v8/issues/detail?id=5537#c4

ljharb commented 7 years ago

Thanks; i'm subscribed and it's already linked in the OP :-)

littledan commented 5 years ago

Sorry that I am catching this a bit late, but I am wondering about the wording of this PR, which was set in this commit in response to this thread. I am wondering, how did you arrive at this wording, rather than using the wording in @domenic's suggestion?

ljharb commented 5 years ago

Which PR are you referring to?

littledan commented 5 years ago

https://github.com/tc39/proposal-global/commit/a415fa5719d9d92fd7cd5f653417d820701b909c

ljharb commented 5 years ago

ah, that's just a commit, not a PR.

I don't remember exactly; but I think we discussed it offline and @domenic was satisfied with this rewording. If not, a new issue or PR is welcome; it'd be a minor editorial tweak (and it could also be commented directly on the spec PR)

littledan commented 5 years ago

Is there anything you could say about why you went towards this wording rather than the wording Domenic suggested? I can't find information about it in commit messages or bug threads.

ljharb commented 5 years ago

Nope, I’m afraid i can’t remember my reasons from 2 years ago. I believe it seemed like the most minimal modification to the existing text. Since Domenic hasn’t brought it up, do you have a preference for an alternative?

littledan commented 5 years ago

I have a preference for the wording Domenic suggested, all else being equal. It seems unnecessary to me to create another separate name for the global this value, when we already have another way of referring to it.

ljharb commented 5 years ago

I’m worried about this part: https://github.com/tc39/proposal-global/issues/17#issuecomment-250015534

Jack-Works commented 5 years ago

globalThis has already available without a flag in Chrome 70

targos commented 5 years ago

@Jack-Works It isn't by default. You probably have enabled the "Experimental JavaScript" flag.

Jack-Works commented 5 years ago

@targos oh yes I forgot it

andylima commented 5 years ago

It's in Chrome 71 (beta):

V8 v7.1 also adds support for the globalThis proposal, enabling a universal mechanism to access the global object even in strict functions or modules regardless of the platform.

https://v8.dev/blog/v8-release-71

chicoxyzzy commented 5 years ago

It's implemented in SpiderMonkey

mathiasbynens commented 5 years ago

In case you want to update the OP: globalThis was implemented in Chrome 70 behind a flag and (as you already note) shipped unflagged in Chrome 71.

ljharb commented 5 years ago

Thanks :-) the OP already notes this.

mathiasbynens commented 5 years ago

@ljharb It doesn’t currently note that it shipped behind a flag in Chrome 70.

ljharb commented 5 years ago

ah true, thanks, updating now

michaelficarra commented 5 years ago

@ljharb Will you be bringing this proposal before the committee for stage 4 at the next meeting?

ljharb commented 5 years ago

Quite possibly, as soon as i have the stomach for further internet outrage.