tc39 / proposal-global

ECMAScript Proposal, specs, and reference implementation for `global`
http://tc39.github.io/proposal-global/
MIT License
349 stars 18 forks source link

use PropertyDescriptor named schema to describe the property #13

Closed michaelficarra closed 8 years ago

michaelficarra commented 8 years ago

The spec says

Schema for commonly used Record field combinations may be named, and that name may be used as a prefix to a literal Record value to identify the specific kind of aggregations that is being described. For example: PropertyDescriptor { [[Value]]: 42, [[Writable]]: false, [[Configurable]]: true }.

And this style is used throughout. I would prefer it to the current

This is a data property with an initial value of the global object.

This property has the attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }.

ljharb commented 8 years ago

I see 93 uses of "has the attributes" used without a value, and 62 (not including the definition) instances of "[[Value]]". Of those 62, only 36 appear to be for property descriptors.

It would appear that the precedent is to not explicitly use the value - @bterlson, do you have a preference? (#9)

ljharb commented 8 years ago

Discussed with @bterlson - let's keep this as-is, and unify separately if desired.