Spec reviewer signoff - Githubissues

tc39 / proposal-global

ECMAScript Proposal, specs, and reference implementation for `global`

http://tc39.github.io/proposal-global/

MIT License

349 stars 18 forks source link

Closed ljharb closed 7 years ago

ljharb commented 8 years ago

Part of the stage 2 → 3 requirements is signoff from the official spec reviewers.

erights commented 8 years ago

Approved.

caridy commented 8 years ago

LGTM (let's discuss #14 tomorrow)

michaelficarra commented 8 years ago

LGTM.

ljharb commented 8 years ago

Thanks, everyone!

ljharb commented 7 years ago

This now needs rereview:

Plus the additional members that indicated interest:

michaelficarra commented 7 years ago

LGTM.

ljharb commented 7 years ago

👍 from @allenwb and @erights verbally

erights commented 7 years ago

As Jordan noted, I approve.

caridy commented 7 years ago

LGTM, just one extra space after [[ in 3->2.b step: Let globalObj be ObjectCreate(intrinsics.[[ %ObjectPrototype%]]).

ljharb commented 7 years ago

Actually that space isn't in the source, so it must be an ecmarkup bug. Thanks!