search

tc39 / proposal-import-attributes

Proposal for syntax to import ES modules with assertions
https://tc39.es/proposal-import-attributes/
Apache License 2.0
599 stars 26 forks source link

Rename HostGetSupportedAssertions to HostGetSupportedImportAssertions #105

Closed dandclark closed 4 years ago

dandclark commented 4 years ago

I realized when starting to look at implementing this callback in V8 that when the name HostGetSupportedAssertions is seen out of context, it is pretty vague. A reader might initially assume that this refers to some other type of assertions. Therefore I'd like to consider renaming this to HostGetSupportedImportAssertions so that there is a clearer association with this feature.

dandclark commented 4 years ago

@littledan Thanks for reviewing! Am I correct in assuming that it's appropriate to merge in a simple rename like this without waiting for committee consensus?

littledan commented 4 years ago

Yes