tc39 / proposal-import-attributes

Proposal for syntax to import ES modules with assertions

https://tc39.es/proposal-import-attributes/

Apache License 2.0

599 stars 26 forks source link

Consider more name change fallout from 'if' --> 'assert' rename #87

Closed dandclark closed 4 years ago

dandclark commented 4 years ago

80 changed the keyword from `if` to `assert`. There are two other name changes to consider as follow-ups:

Rename the proposal from "Import Conditions" to "Import Assertions"
Rename ModuleRecord's [[Conditions]] fields to [[Assertions]]

Thoughts/objections/any other changes we're missing?

xtuc commented 4 years ago

We might want to update Mozilla's position

dandclark commented 4 years ago

Other parts of spec text also reference "conditions" (ConditionEntries, ConditionKey, AssertClauseToConditions...), so I'm renaming those as well in #88.

dandclark commented 4 years ago

I landed #88 and posted an update to https://github.com/mozilla/standards-positions/issues/373 (if they want to change it I'll offer to submit a PR; I'm not sure if creating a PR against mozilla/standards-position as a non-Mozilla employee presumes too much 😄). So, closing this.

xtuc commented 4 years ago

@dandclark I think it's ok to do it, like I did https://github.com/mozilla/standards-positions/pull/392. I'm happy to send a PR

dandclark commented 4 years ago

@xtuc Oh, I didn't notice it was done that way last time. Looks like dbaron beat us to it though: https://github.com/mozilla/standards-positions/commit/da631527be5346a8993496e9d9f1cf36219bde12

tc39 / proposal-import-attributes

Consider more name change fallout from 'if' --> 'assert' rename #87

80 changed the keyword from if to assert. There are two other name changes to consider as follow-ups:

80 changed the keyword from `if` to `assert`. There are two other name changes to consider as follow-ups: