Address Shu's stage 3 review feedback

tc39 / proposal-import-attributes

Proposal for syntax to import ES modules with assertions

https://tc39.es/proposal-import-attributes/

Apache License 2.0

569 stars 32 forks source link

Closed dandclark closed 3 years ago

dandclark commented 3 years ago

Address @syg's review feedback:

AssertClauseToAssertions should be Static Semantics.
Pulled conversion of AssertionKey to string into separate Static Semantics: StringValue section so that AssertClauseToAssertions isn't so overloaded.
Fix typo in 2.1.1 step 10.e.3: "[[Value]], -> [[Value]]:".
Update Sample Integration section to more closely reflect the current state of the HTML integration..

syg commented 3 years ago

(For clarity Dan's capturing what I communicated via email.)