search

tc39 / proposal-intl-displaynames-v2

Intl DisplayNames API V2
https://tc39.es/proposal-intl-displaynames-v2/
MIT License
23 stars 3 forks source link

Review: Clarify the purpose of [[DialectHandling]] better #24

Closed ryzokuken closed 3 years ago

ryzokuken commented 3 years ago

Minor review comment, but I feel that https://github.com/tc39/intl-displaynames-v2/blob/f09181795aac6414fa2273658f126163566a0335/displaynames.html#L363 should do a better job of explaining the [[DialectHandling]] slot. More specifically, it should mention that the value only affects the result of type = "language" and none of the other cases...

FrankYFTang commented 3 years ago

type = "location"

I assume you mean type = "language", right?

ryzokuken commented 3 years ago

Oh I am sorry, yes.

FrankYFTang commented 3 years ago

Thanks for the feedback. I will looks into this tonight.